code review 6620075: cmd/ld, cmd/6l, cmd/8l: sort exported dynamic symbols f...

cmd/ld, cmd/6l, cmd/8l: sort exported dynamic symbols for Darwin
Also corrected cmd/8l's .dynsym handling (differentiate between exported symbols and imported symbols)

        Fixes issue 4029.

[minux1, 2012-10-09 15:40:19]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2012-10-09 15:43:57]

I'd like to ask someone who can access Mountain Lion help me test this
(I can only verify by 'objdump -t')

Test procedure (two things to verify):
cd $GOROOT/src
hg clp 6620075
go test ../misc/cgo # verify the added test should fail

./all.bash # verify w/ this CL, all tests should pass

[rsc, 2012-10-09 15:52:53]

> Test procedure (two things to verify):
> cd $GOROOT/src
> hg clp 6620075
> go test ../misc/cgo # verify the added test should fail

used ../misc/cgo/test here

> ./all.bash # verify w/ this CL, all tests should pass

it passes

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.8.2
BuildVersion:	12C54
$

[minux1, 2012-10-09 16:00:30]

Thank you very much.

On Tue, Oct 9, 2012 at 11:52 PM, Russ Cox <rsc@golang.org> wrote:

> > hg clp 6620075
> > go test ../misc/cgo # verify the added test should fail
>
> used ../misc/cgo/test here
>
oops, yeah. just to confirm: did it fail?

If it failed, then this CL is ready to be reviewed.

[rsc, 2012-10-09 16:40:10]

yes, it failed before all.bash and passed during all.bash

[minux1, 2012-10-09 16:45:20]

On Wed, Oct 10, 2012 at 12:40 AM, Russ Cox <rsc@golang.org> wrote:

> yes, it failed before all.bash and passed during all.bash
>
Thank you for the confirmation. I'm glad I made it work without Mountain
Lion.

[rsc, 2012-10-09 16:48:00]

LGTM

[minux1, 2012-10-09 16:56:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=62b7ebe62958 ***

cmd/ld, cmd/6l, cmd/8l: sort exported dynamic symbols for Darwin
Also corrected cmd/8l's .dynsym handling (differentiate between exported symbols
and imported symbols)

        Fixes issue 4029.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6620075