code review 6620070: test: use rundir and errorcheckdir for a few more tests.

test: use rundir and errorcheckdir for a few more tests.

Update issue 4139.

[remyoudompheng, 2012-10-07 16:25:27]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[remyoudompheng, 2012-10-07 16:26:14]

A few main.go files are renamed prog.go or program.go to be lexicographically
after p1.go or pkg.go

[minux1, 2012-10-07 16:32:04]

LGTM.

On 2012/10/07 16:26:14, remyoudompheng wrote:
> A few main.go files are renamed prog.go or program.go to be lexicographically
> after p1.go or pkg.go
What some is renamed to program.go, and some to prog.go?

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug160.go
File test/fixedbugs/bug160.go (right):

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug160.go#newc...
test/fixedbugs/bug160.go:7: nothing to see here
package ignored

for consistency with others?

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug322.go
File test/fixedbugs/bug322.go (right):

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug322.go#newc...
test/fixedbugs/bug322.go:8: ignored
same

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug324.go
File test/fixedbugs/bug324.go (right):

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug324.go#newc...
test/fixedbugs/bug324.go:10: ignored
same

[remyoudompheng, 2012-10-07 16:35:15]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[remyoudompheng, 2012-10-07 16:36:29]

On 2012/10/07 16:32:04, minux wrote:
> LGTM.
> 
> On 2012/10/07 16:26:14, remyoudompheng wrote:
> > A few main.go files are renamed prog.go or program.go to be
lexicographically
> > after p1.go or pkg.go
> What some is renamed to program.go, and some to prog.go?

Only because I changed my mind in the middle so now everyone is prog.go

[remyoudompheng, 2012-10-07 16:37:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=c5101bdd9f67 ***

test: use rundir and errorcheckdir for a few more tests.

Update issue 4139.

R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6620070

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug160.go
File test/fixedbugs/bug160.go (right):

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug160.go#newc...
test/fixedbugs/bug160.go:7: nothing to see here
On 2012/10/07 16:32:04, minux wrote:
> package ignored
> 
> for consistency with others?

Done.

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug322.go
File test/fixedbugs/bug322.go (right):

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug322.go#newc...
test/fixedbugs/bug322.go:8: ignored
On 2012/10/07 16:32:04, minux wrote:
> same

Done.

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug324.go
File test/fixedbugs/bug324.go (right):

http://codereview.appspot.com/6620070/diff/3013/test/fixedbugs/bug324.go#newc...
test/fixedbugs/bug324.go:10: ignored
On 2012/10/07 16:32:04, minux wrote:
> same

Done.