Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80)

Issue 6619056: code review 6619056: image/jpeg: add DCT tests, do a small optimization (com... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by nigeltao
Modified:
12 years, 5 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

image/jpeg: add DCT tests, do a small optimization (common sub-expression elimination) in idct.go. benchmark old ns/op new ns/op delta BenchmarkIDCT 5649 5610 -0.69% BenchmarkDecodeRGBOpaque 2948607 2941051 -0.26% The "type block" declaration moved so that idct.go is compilable as a stand-alone file: "go tool 6g -S idct.go" works.

Patch Set 1 #

Patch Set 2 : diff -r 591de8123cb5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 591de8123cb5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e2ec9e45d282 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -33 lines) Patch
A src/pkg/image/jpeg/dct_test.go View 1 1 chunk +297 lines, -0 lines 0 comments Download
M src/pkg/image/jpeg/idct.go View 1 5 chunks +36 lines, -29 lines 0 comments Download
M src/pkg/image/jpeg/reader.go View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/pkg/image/jpeg/writer_test.go View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 5 months ago (2012-10-06 07:12:41 UTC) #1
r
LGTM
12 years, 5 months ago (2012-10-06 11:51:35 UTC) #2
nigeltao
12 years, 5 months ago (2012-10-06 23:21:23 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=b32301e11025 ***

image/jpeg: add DCT tests, do a small optimization (common sub-expression
elimination) in idct.go.

benchmark                   old ns/op    new ns/op    delta
BenchmarkIDCT                    5649         5610   -0.69%
BenchmarkDecodeRGBOpaque      2948607      2941051   -0.26%

The "type block" declaration moved so that idct.go is compilable
as a stand-alone file: "go tool 6g -S idct.go" works.

R=r
CC=golang-dev
http://codereview.appspot.com/6619056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b