code review 6615061: encoding/base{32,64}: add examples.

encoding/base{32,64}: add examples.

Fixes issue 4136.

[dsymonds, 2012-10-08 11:41:04]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2012-10-08 11:41:59]

I can copy (and adjust) this file to encoding/base32 if it seems
worthwhile, but base64 is the one that everyone wants to use, so I
think it'd be fine to just do this one.

[r, 2012-10-08 12:03:56]

LGTM but why not do the other too? no one has complained yet about having too
many examples

http://codereview.appspot.com/6615061/diff/5001/src/pkg/encoding/base64/examp...
File src/pkg/encoding/base64/example_test.go (right):

http://codereview.appspot.com/6615061/diff/5001/src/pkg/encoding/base64/examp...
src/pkg/encoding/base64/example_test.go:14:
fmt.Println(base64.StdEncoding.EncodeToString(data))
break this into two lines, so the fmt.Println doesn't hide the part you're
exampling.

[dsymonds, 2012-10-08 21:15:16]

http://codereview.appspot.com/6615061/diff/5001/src/pkg/encoding/base64/examp...
File src/pkg/encoding/base64/example_test.go (right):

http://codereview.appspot.com/6615061/diff/5001/src/pkg/encoding/base64/examp...
src/pkg/encoding/base64/example_test.go:14:
fmt.Println(base64.StdEncoding.EncodeToString(data))
On 2012/10/08 12:03:56, r wrote:
> break this into two lines, so the fmt.Println doesn't hide the part you're
> exampling.

Done.

[dsymonds, 2012-10-08 21:15:28]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-10-08 21:31:06]

LGTM

[dsymonds, 2012-10-08 21:56:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=6b1ad2dd1fbc ***

encoding/base{32,64}: add examples.

Fixes issue 4136.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6615061