Issue 6610051: code review 6610051: go/printer, gofmt: don't forget the .0 in 1.0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6610051: code review 6610051: go/printer, gofmt: don't forget the .0 in 1.0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by gri

Modified:
11 years, 7 months ago

Reviewers:

CC:
r, bsiegert, 0xjnml, bradfitz, golang-dev

Visibility:
Public.

Description

go/printer: don't forget the .0 in 1.0 (use floating-point rather then integer constant division) gofmt -w src misc Fixes issue 3965.

Patch Set 1 #

Patch Set 2 : diff -r 81bcdaeedc63 https://code.google.com/p/go #

Patch Set 3 : diff -r 81bcdaeedc63 https://code.google.com/p/go #

Patch Set 4 : diff -r 81bcdaeedc63 https://code.google.com/p/go #

Patch Set 5 : diff -r 81bcdaeedc63 https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -1 line)			Patch
M	src/pkg/go/printer/nodes.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/printer/testdata/declarations.golden	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/declarations.input	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: bradfitz@golang.org, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2012-10-05 05:16:37 UTC) #1

bsiegert

I thought this kind of thing was not required in Go because numbers are 'perfect' ...

11 years, 7 months ago (2012-10-05 10:58:15 UTC) #2

0xjnml

On Fri, Oct 5, 2012 at 12:58 PM, Benny Siegert <bsiegert@gmail.com> wrote: > I thought ...

11 years, 7 months ago (2012-10-05 11:01:54 UTC) #3

That's the point - he wants 1/4 not 0.0. http://play.golang.org/p/L_zs7wWpjs -rob

11 years, 7 months ago (2012-10-05 12:25:48 UTC) #5

gri

11 years, 7 months ago (2012-10-05 15:48:30 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=3ad42a0f9fc6 ***

go/printer: don't forget the .0 in 1.0

(use floating-point rather then integer constant division)

gofmt -w src misc

Fixes issue 3965.

R=r, bsiegert, 0xjnml
CC=bradfitz, golang-dev
http://codereview.appspot.com/6610051

Expand All Messages | Collapse All Messages