code review 6609051: test: convert more tests to rundir/compiledir conventions

test: convert more tests to rundir/compiledir conventions

Update issue 4139.

[remyoudompheng, 2012-10-07 17:17:00]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[remyoudompheng, 2012-10-07 17:18:26]

The bug191.out thing has issues satisfying both run.go and the bash run, and
will be flaky if init order changes.

rsc: what is bug191 testing?

[rsc, 2012-10-07 19:57:33]

bug191 was testing that when you import . both "a" and "b", the two init symbols
do not get imported and collide with each other.

It didn't used to look at the output, just that the program compiled.

http://codereview.appspot.com/6609051/diff/5001/test/fixedbugs/bug191.out
File test/fixedbugs/bug191.out (right):

http://codereview.appspot.com/6609051/diff/5001/test/fixedbugs/bug191.out#new...
test/fixedbugs/bug191.out:1: b
This is a surprise to me. The main.go imports a then b. Why does it print b then
a? I would have expected the imports to run in the order in the file. We should
probably fix that.

[rsc, 2012-10-07 19:59:39]

LGTM

Thanks for cleaning these up.

http://codereview.appspot.com/6609051/diff/5001/test/fixedbugs/bug191.dir/mai...
File test/fixedbugs/bug191.dir/main.go (left):

http://codereview.appspot.com/6609051/diff/5001/test/fixedbugs/bug191.dir/mai...
test/fixedbugs/bug191.dir/main.go:1: // $G $D/bug191.dir/a.go && $G
$D/bug191.dir/b.go && $G $D/$F.go && $L $F.$A
Is fixedbugs/bug191.go missing? It could be compiledir I think.

[remyoudompheng, 2012-10-07 21:17:12]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[remyoudompheng, 2012-10-07 21:23:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=1571ae601243 ***

test: convert more tests to rundir/compiledir conventions

Update issue 4139.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6609051