Issue 6589070: code review 6589070: go-tour: add copyright notices

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6589070: code review 6589070: go-tour: add copyright notices (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by francesc

Modified:
12 years, 5 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

go-tour: add copyright notices

Patch Set 1 #

Patch Set 2 : diff -r bb8e3b14b929 https://code.google.com/p/go-tour #

Patch Set 3 : diff -r bb8e3b14b929 https://code.google.com/p/go-tour #

Patch Set 4 : diff -r bb8e3b14b929 https://code.google.com/p/go-tour #

Patch Set 5 : diff -r bb8e3b14b929 https://code.google.com/p/go-tour #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
M	gotour/solutions/binarytrees.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gotour/solutions/complexcube.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gotour/solutions/errors.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gotour/solutions/fib.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gotour/solutions/image.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gotour/solutions/loops.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gotour/solutions/maps.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gotour/solutions/rot13.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gotour/solutions/slices.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gotour/solutions/webcrawler.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

francesc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

12 years, 5 months ago (2012-10-03 23:45:45 UTC) #1

adg

LGTM But please rename this CL "go-tour: add copyright notices" (note the dash in "go-tour", ...

12 years, 5 months ago (2012-10-03 23:48:13 UTC) #2

francesc

Hello adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 5 months ago (2012-10-03 23:53:25 UTC) #3

francesc

12 years, 5 months ago (2012-10-03 23:54:48 UTC) #4

*** Submitted as http://code.google.com/p/go-tour/source/detail?r=e3153ab31a06
***

go-tour: add copyright notices

R=adg
CC=golang-dev
http://codereview.appspot.com/6589070

Expand All Messages | Collapse All Messages