Issue 65850043: code review 65850043: cmd/gc: fix array index out of bounds error message

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 65850043: code review 65850043: cmd/gc: fix array index out of bounds error message (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rick

Modified:
11 years, 1 month ago

Reviewers:
r, gobot

CC:
golang-codereviews, r

Visibility:
Public.

Description

cmd/gc: fix array index out of bounds error message The error message was previously off by one in all cases. Fixes issue 7150.

Patch Set 1 #

Patch Set 2 : diff -r 4cc450928949 https://code.google.com/p/go #

Patch Set 3 : diff -r 4cc450928949 https://code.google.com/p/go #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
	M	src/cmd/gc/typecheck.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	A	test/fixedbugs/issue7150.go	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rick

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 1 month ago (2014-02-19 02:47:34 UTC) #1

*** Submitted as https://code.google.com/p/go/source/detail?r=d93672dab213 *** cmd/gc: fix array index out of bounds error message The ...

11 years, 1 month ago (2014-02-19 19:28:30 UTC) #3

gobot

This CL appears to have broken the netbsd-386-minux builder.

11 years, 1 month ago (2014-02-19 19:38:53 UTC) #4

On it. On Wed, Feb 19, 2014 at 11:38 AM, <gobot@golang.org> wrote: > This CL ...

11 years, 1 month ago (2014-02-19 19:48:32 UTC) #5

11 years, 1 month ago (2014-02-19 20:00:56 UTC) #6

https://codereview.appspot.com/66110043 should fix it

On Wed, Feb 19, 2014 at 11:48 AM, Rob Pike <r@golang.org> wrote:
> On it.
>
> On Wed, Feb 19, 2014 at 11:38 AM,  <gobot@golang.org> wrote:
>> This CL appears to have broken the netbsd-386-minux builder.
>>
>> https://codereview.appspot.com/65850043/

Expand All Messages | Collapse All Messages