code review 6572049: spec: permit trailing comma in conversions

spec: permit trailing comma in conversions

Also: Adjust prose in Conversions section
to be consistent.

This is a backward-compatible syntax change.
For a discussion see issue 2568.

Fixes issue 2568.
Fixes issue 4123.

[gri, 2012-09-26 01:46:37]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2012-09-26 02:21:17]

LGTM

[iant2, 2012-09-26 04:53:48]

LGTM

On Tue, Sep 25, 2012 at 6:46 PM,  <gri@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> spec: permit trailing comma in conversions
>
> Also: Adjust prose in Conversions section
> to be consistent.
>
> This is a backward-compatible syntax change.
> For a discussion see issue 2568.
>
> Fixes issue 2568.
> Fixes issue 4123.
>
> Please review this at http://codereview.appspot.com/6572049/
>
> Affected files:
>   M doc/go_spec.html
>
>
> Index: doc/go_spec.html
> ===================================================================
> --- a/doc/go_spec.html
> +++ b/doc/go_spec.html
> @@ -1,6 +1,6 @@
>  <!--{
>         "Title": "The Go Programming Language Specification",
> -       "Subtitle": "Version of September 22, 2012",
> +       "Subtitle": "Version of September 26, 2012",
>         "Path": "/ref/spec"
>  }-->
>
> @@ -3390,7 +3390,7 @@
>  </p>
>
>  <pre class="ebnf">
> -Conversion = Type "(" Expression ")" .
> +Conversion = Type "(" Expression [ "," ] ")" .
>  </pre>
>
>  <p>
> @@ -3464,12 +3464,11 @@
>         <code>x</code>'s type and <code>T</code> are both complex types.
>         </li>
>         <li>
> -       <code>x</code> is an integer or has type <code>[]byte</code> or
> -       <code>[]rune</code> and <code>T</code> is a string type.
> +       <code>x</code> is an integer or a slice of bytes or runes
> +       and <code>T</code> is a string type.
>         </li>
>         <li>
> -       <code>x</code> is a string and <code>T</code> is <code>[]byte</code>
> or
> -       <code>[]rune</code>.
> +       <code>x</code> is a string and <code>T</code> is a slice of bytes or
> runes.
>         </li>
>  </ul>
>
>
>

[rsc, 2012-09-26 17:30:08]

LGTM

[gri, 2012-09-26 17:32:02]

*** Submitted as http://code.google.com/p/go/source/detail?r=83b7e6341263 ***

spec: permit trailing comma in conversions

Also: Adjust prose in Conversions section
to be consistent.

This is a backward-compatible syntax change.
For a discussion see issue 2568.

Fixes issue 2568.
Fixes issue 4123.

R=golang-dev, r, iant, rsc
CC=golang-dev
http://codereview.appspot.com/6572049