Issue 6569067: code review 6569067: encoding/xml: Omit parent tags if value is empty. Fixes...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by vmihailenco

Modified:
10 years, 7 months ago

Reviewers:
gustavo.niemeyer, rsc, luke1, golang-dev

CC:
golang-dev

Visibility:
Public.

encoding/xml: Omit parent tags if value is empty. Fixes issue 4168.

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	src/pkg/encoding/xml/marshal.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/pkg/encoding/xml/marshal_test.go	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 5

vmihailenco

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2012-10-08 10:15:26 UTC) #1

luke1

This patch still works. Can this be included? Many XML API's are very picky about ...

10 years, 7 months ago (2013-09-13 20:40:08 UTC) #4

No. See my reply on the issue tracker.