code review 6552044: crypto/x509: ignore non-critical email constraints

crypto/x509: ignore non-critical email constraints

Previously we tried to parse email constraints as the maximum base
distance (which is unused and must be omitted according to RFC 5280)
because they share the same tag number. Rather than complicate the
code further, this CL just ignores the unused values.

[agl1, 2012-09-20 13:21:03]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-09-20 15:34:06]

LGTM
 On Sep 20, 2012 6:21 AM, <agl@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> crypto/x509: ignore non-critical email constraints
>
> Previously we tried to parse email constraints as the maximum base
> distance (which is unused and must be omitted according to RFC 5280)
> because they share the same tag number. Rather than complicate the
> code further, this CL just ignores the unused values.
>
> Please review this at
http://codereview.appspot.com/**6552044/<http://codereview.appspot.com/6552044/>
>
> Affected files:
>   M src/pkg/crypto/x509/x509.go
>
>
> Index: src/pkg/crypto/x509/x509.go
> ==============================**==============================**=======
> --- a/src/pkg/crypto/x509/x509.go
> +++ b/src/pkg/crypto/x509/x509.go
> @@ -613,8 +613,6 @@
>
>  type generalSubtree struct {
>         Name string `asn1:"tag:2,optional,ia5"`
> -       Min  int    `asn1:"optional,tag:0"`
> -       Max  int    `asn1:"optional,tag:1"`
>  }
>
>  func parsePublicKey(algo PublicKeyAlgorithm, keyData *publicKeyInfo)
> (interface{}, error) {
> @@ -831,7 +829,7 @@
>                                 }
>
>                                 for _, subtree := range
> constraints.Permitted {
> -                                       if subtree.Min > 0 || subtree.Max
> > 0 || len(subtree.Name) == 0 {
> +                                       if len(subtree.Name) == 0 {
>                                                 if e.Critical {
>                                                         return out,
> UnhandledCriticalExtension{}
>                                                 }
>
>
>

[agl1, 2012-09-20 16:31:08]

*** Submitted as http://code.google.com/p/go/source/detail?r=2dd9cac9ab39 ***

crypto/x509: ignore non-critical email constraints

Previously we tried to parse email constraints as the maximum base
distance (which is unused and must be omitted according to RFC 5280)
because they share the same tag number. Rather than complicate the
code further, this CL just ignores the unused values.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6552044