code review 6551056: [release-branch.go1] syscall: use exported StringToUTF1...

[release-branch.go1] syscall: use exported StringToUTF16 in windows test

[adg, 2012-09-21 21:32:50]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-09-21 22:03:02]

LGTM

Please double-check for me that the copy of StringToUTF16 in the release branch
panics if there are NULs in the string.

[adg, 2012-09-21 22:05:25]

On 21 September 2012 15:03,  <rsc@golang.org> wrote:
> LGTM
>
> Please double-check for me that the copy of StringToUTF16 in the release
> branch panics if there are NULs in the string.

Yup

// StringToUTF16 returns the UTF-16 encoding of the UTF-8 string s.
// If s contains a NUL byte this function panics instead of
// returning an error.
func StringToUTF16(s string) []uint16 {
        a, err := utf16FromString(s)
        if err != nil {
                panic("syscall: string with NUL passed to StringToUTF16")
        }
        return a
}

[adg, 2012-09-21 22:10:20]

Ah, it should have been StringToUTF16Ptr. Thank heavens for cross compilation.

GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go test -c

[adg, 2012-09-21 22:10:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=2d8bc3c94ecb ***

[release-branch.go1] syscall: use exported StringToUTF16 in windows test

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6551056