code review 6536047: builtin: Changed documentation for rune type.

builtin: Changed documentation for rune type.
Fixes issue 4093.

[anthony.eufemio, 2012-09-18 15:08:09]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2012-09-18 17:27:27]

CONTRIBUTORS changes must be done separately.

Remove that part from the CL and we can do the AUTHORS and CONTRIBUTORS
part.


On Tue, Sep 18, 2012 at 8:08 AM, <anthony.eufemio@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> builtin: Changed documentation for rune type.
> Fixes issue 4093.
>
> Please review this at
http://codereview.appspot.com/**6536047/<http://codereview.appspot.com/6536047/>
>
> Affected files:
>   M CONTRIBUTORS
>   M src/pkg/builtin/builtin.go
>
>
> Index: CONTRIBUTORS
> ==============================**==============================**=======
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -54,6 +54,7 @@
>  Andy Davis <andy@bigandian.com>
>  Anh Hai Trinh <anh.hai.trinh@gmail.com>
>  Anschel Schaffer-Cohen <anschelsc@gmail.com>
> +Anthony Eufemio <anthony.eufemio@gmail.com>
>  Anthony Martin <ality@pbrane.org>
>  Anthony Starks <ajstarks@gmail.com>
>  Aron Nopanen <aron.nopanen@gmail.com>
> Index: src/pkg/builtin/builtin.go
> ==============================**==============================**=======
> --- a/src/pkg/builtin/builtin.go
> +++ b/src/pkg/builtin/builtin.go
> @@ -81,9 +81,8 @@
>  // integer values.
>  type byte byte
>
> -// rune is an alias for int and is equivalent to int in all ways. It is
> +// rune is an alias for int32 and is equivalent to int32 in all ways. It
> is
>  // used, by convention, to distinguish character values from integer
> values.
> -// In a future version of Go, it will change to an alias of int32.
>  type rune rune
>
>  // Type is here for the purposes of documentation only. It is a stand-in
>
>
>

[bradfitz, 2012-09-18 17:28:17]

Also, it looks like you haven't submitted the CLA.

See http://golang.org/doc/contribute.html#copyright


On Tue, Sep 18, 2012 at 8:08 AM, <anthony.eufemio@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> builtin: Changed documentation for rune type.
> Fixes issue 4093.
>
> Please review this at
http://codereview.appspot.com/**6536047/<http://codereview.appspot.com/6536047/>
>
> Affected files:
>   M CONTRIBUTORS
>   M src/pkg/builtin/builtin.go
>
>
> Index: CONTRIBUTORS
> ==============================**==============================**=======
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -54,6 +54,7 @@
>  Andy Davis <andy@bigandian.com>
>  Anh Hai Trinh <anh.hai.trinh@gmail.com>
>  Anschel Schaffer-Cohen <anschelsc@gmail.com>
> +Anthony Eufemio <anthony.eufemio@gmail.com>
>  Anthony Martin <ality@pbrane.org>
>  Anthony Starks <ajstarks@gmail.com>
>  Aron Nopanen <aron.nopanen@gmail.com>
> Index: src/pkg/builtin/builtin.go
> ==============================**==============================**=======
> --- a/src/pkg/builtin/builtin.go
> +++ b/src/pkg/builtin/builtin.go
> @@ -81,9 +81,8 @@
>  // integer values.
>  type byte byte
>
> -// rune is an alias for int and is equivalent to int in all ways. It is
> +// rune is an alias for int32 and is equivalent to int32 in all ways. It
> is
>  // used, by convention, to distinguish character values from integer
> values.
> -// In a future version of Go, it will change to an alias of int32.
>  type rune rune
>
>  // Type is here for the purposes of documentation only. It is a stand-in
>
>
>

[r, 2012-09-18 17:33:33]

Alternatively, for a change this small if you'd prefer we could just
make it for  you, with thanks.

-rob

[bradfitz, 2012-09-18 17:34:33]

The CLA is now in and verified.

On Tue, Sep 18, 2012 at 10:33 AM, Rob Pike <r@golang.org> wrote:

> Alternatively, for a change this small if you'd prefer we could just
> make it for  you, with thanks.
>
> -rob
>

[anthony.eufemio, 2012-09-18 17:50:35]

Hello golang-dev@googlegroups.com, bradfitz@golang.org, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-09-18 17:59:43]

LGTM

On Tue, Sep 18, 2012 at 10:50 AM, <anthony.eufemio@gmail.com> wrote:

> Hello golang-dev@googlegroups.com, bradfitz@golang.org, r@golang.org
> (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**6536047/<http://codereview.appspot.com/6536047/>
>

[bradfitz, 2012-09-18 18:01:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=6cfab3a0935e ***

builtin: Changed documentation for rune type.
Fixes issue 4093.

R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/6536047

Committer: Brad Fitzpatrick <bradfitz@golang.org>