code review 6533050: net: avoid passing an empty string as a parameter to Li...

net: avoid passing an empty string as a parameter to Listen, ListenPacket

Fixes issue 3847.
Update issue 3721.
Update issue 3548.

[mikio, 2012-10-04 09:37:00]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2012-10-13 17:14:42]

ping

[iant, 2012-10-13 17:33:30]

It seems like this will break existing programs that want to use net.Listen or
net.ListenPacket with a wildcard local address.  Are you saying that those
programs are already broken?  We need to provide some mechanism for programs to
listen on a wildcard address.  And if we have that mechanism, why not use the
empty string to ask for it?

So this doesn't seem to me like a good way to go.

https://codereview.appspot.com/6533050/diff/8001/src/pkg/net/dial.go
File src/pkg/net/dial.go (right):

https://codereview.appspot.com/6533050/diff/8001/src/pkg/net/dial.go#newcode66
src/pkg/net/dial.go:66: // For TCP and UDP networks, addr has the
colon-separeted form
s/separeted/separated/

But I'm not sure why adding "colon-separated" is helpful here--the example
already shows a colon.  Why not just leave it as it is?

https://codereview.appspot.com/6533050/diff/8001/src/pkg/net/dial.go#newcode170
src/pkg/net/dial.go:170: // For TCP networks, laddr has the colon-separeted form
"host:port".
s/separeted/separated/

https://codereview.appspot.com/6533050/diff/8001/src/pkg/net/dial.go#newcode195
src/pkg/net/dial.go:195: // For UDP networks, laddr has the colon-separeted form
"host:port".
s/separeted/separated/

[rsc, 2012-10-21 21:24:01]

Same comments. Same program too: s/ListenTCP("tcp", nil)/Listen("tcp",
"")/. For better or worse, we appear to have committed to allowing
this. Let's make l.Addr() say the right thing.

Russ

[mikio, 2012-11-12 15:43:53]

*** Abandoned ***