code review 65280043: dist: Replaces xprintf() and related on Windows with vp...

dist: Replaces xprintf() and related on Windows with vprintf() calls, rather than using vsnprintf() in an undocumented way to get the length of the output string and Windows API I/O calls to write an xmalloc()-ed buffer out. The undocumented functionality did not work on Windows 2000, which is listed as supported by Go, and thus dist would not output anything, and the build fails early.
Fixes issue 7242.

[Pietro Gagliardi (andlabs), 2014-02-18 03:36:14]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[brainman, 2014-02-19 01:21:26]

LGTM

but change CL description. First line in CL description must be a short
description of what the CL does (the description is used by some tools, like
http://build.golang.org). It also must start with full command or package path
(it is used for some tools too, like https://go-dev.appspot.com). So yours
should be something like:

cmd/dist: use vprintf to print to stdout / stderr on windows

Then you can add long description on the next line (most people also leave blank
line in between). But I think you should description is good enough (up to you).
You have "Fixes issue 7242" line there, so everyone will be able to find
details.

You also need to sign contributor license agreement (as described here
http://golang.org/doc/contribute.html#copyright) before we can submit. Please
let us know here once signed, and someone will submit your change then.

I will wait for a week to give others chance to comment, then submit.

Thank you.

Alex

[brainman, 2014-02-26 01:03:37]

Pietro,

Please, change CL description and sign agreement, and I will submit.

Alex

[rsc, 2014-03-05 19:16:55]

R=close

I submitted CL 71550044