Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(112)

Issue 6525049: code review 6525049: src/all.bat: fix banner (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by minux1
Modified:
11 years, 6 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

src/all.bat: fix banner we need to restore %PATH% before calling "dist banner", so that it could suggest the user to add %GOROOT%/bin to %PATH% if necessary.

Patch Set 1 #

Patch Set 2 : diff -r b0c749cc5654 https://code.google.com/p/go #

Patch Set 3 : diff -r b0c749cc5654 https://code.google.com/p/go #

Patch Set 4 : diff -r 80ab25ffe4ca https://code.google.com/p/go/ #

Patch Set 5 : diff -r 80ab25ffe4ca https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/all.bat View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 6 months ago (2012-09-19 12:36:53 UTC) #1
bradfitz
LGTM but... maybe the 3rd time rearranging 3 lines is a sign we should add ...
11 years, 6 months ago (2012-09-19 15:37:15 UTC) #2
minux1
On Wednesday, September 19, 2012, Brad Fitzpatrick wrote: > > maybe the 3rd time rearranging ...
11 years, 6 months ago (2012-09-19 15:56:46 UTC) #3
bradfitz
On Wed, Sep 19, 2012 at 8:56 AM, minux <minux.ma@gmail.com> wrote: > > On Wednesday, ...
11 years, 6 months ago (2012-09-19 16:12:48 UTC) #4
minux1
On 2012/09/19 16:12:48, bradfitz wrote: > Whatever comments are helpful without being noisy. I was ...
11 years, 6 months ago (2012-09-19 16:49:09 UTC) #5
bradfitz
LGTM On Wed, Sep 19, 2012 at 9:49 AM, <minux.ma@gmail.com> wrote: > On 2012/09/19 16:12:48, ...
11 years, 6 months ago (2012-09-19 16:50:23 UTC) #6
minux1
11 years, 6 months ago (2012-09-19 16:58:49 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=2f7827571b44 ***

src/all.bat: fix banner
we need to restore %PATH% before calling "dist banner", so that
it could suggest the user to add %GOROOT%/bin to %PATH% if necessary.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6525049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b