Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 6506083: code review 6506083: spec: ignore BOMS outside of string and rune literals. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by r
Modified:
12 years, 7 months ago
Reviewers:
dsymonds
CC:
golang-dev, rsc, 0xjnml
Visibility:
Public.

Description

spec: ignore BOMS outside of string and rune literals. Happy Birthday UTF-8.

Patch Set 1 #

Patch Set 2 : diff -r 43de2903aae0 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M doc/go_spec.html View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 7 months ago (2012-09-06 16:25:48 UTC) #1
r
Note added for reference: This is a spec change. The current implementations reject source code ...
12 years, 7 months ago (2012-09-06 16:48:23 UTC) #2
rsc
LGTM
12 years, 7 months ago (2012-09-06 17:20:51 UTC) #3
0xjnml
Sad pragmatism. -j
12 years, 7 months ago (2012-09-06 17:34:37 UTC) #4
r
*** Submitted as http://code.google.com/p/go/source/detail?r=4d451585dd02 *** spec: ignore BOMS outside of string and rune literals. Happy ...
12 years, 7 months ago (2012-09-06 17:37:20 UTC) #5
dsymonds
12 years, 7 months ago (2012-09-06 22:26:48 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b