code review 6498120: cmd/dist: emit \r in env -w output

cmd/dist: emit \r in env -w output

go tool dist env -w is supposed to print a Windows batch file.
Normally Windows will execute batch files without \r before \n,
but issue 3060 reports that if the file ends up containing paths
written in Chinese, Windows 7 cannot execute it without the \r.
So add the \r.

Fixes issue 3060.

[rsc, 2012-09-12 16:00:18]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-09-12 16:04:03]

LGTM
On Sep 12, 2012 9:00 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/dist: emit \r in env -w output
>
> go tool dist env -w is supposed to print a Windows batch file.
> Normally Windows will execute batch files without \r before \n,
> but issue 3060 reports that if the file ends up containing paths
> written in Chinese, Windows 7 cannot execute it without the \r.
> So add the \r.
>
> Fixes issue 3060.
>
> Please review this at
http://codereview.appspot.com/**6498120/<http://codereview.appspot.com/6498120/>
>
> Affected files:
>   M src/cmd/dist/build.c
>
>
> Index: src/cmd/dist/build.c
> ==============================**==============================**=======
> --- a/src/cmd/dist/build.c
> +++ b/src/cmd/dist/build.c
> @@ -1352,7 +1352,7 @@
>                 vflag++;
>                 break;
>         case 'w':
> -               format = "set %s=%s\n";
> +               format = "set %s=%s\r\n";
>                 break;
>         default:
>                 usage();
>
>
>

[rsc, 2012-09-12 16:05:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=108165c03c70 ***

cmd/dist: emit \r in env -w output

go tool dist env -w is supposed to print a Windows batch file.
Normally Windows will execute batch files without \r before \n,
but issue 3060 reports that if the file ends up containing paths
written in Chinese, Windows 7 cannot execute it without the \r.
So add the \r.

Fixes issue 3060.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6498120