code review 6498115: doc: make bitwise operators stand out

spec: make bitwise operators stand out

The (and not) arguably sounds like it is trying to say something - and not what?.

Just an idea, won't be hurt if it gets rejected.

[rsc, 2012-09-11 03:06:16]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[dsymonds, 2012-09-11 03:09:18]

LGTM

What about <blink> too?

[dsymonds, 2012-09-11 03:11:08]

http://codereview.appspot.com/6498115/diff/4001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/6498115/diff/4001/doc/go_spec.html#newcode3185
doc/go_spec.html:3185: &&    conditional and    p && q  is  "if
p then q else false"
down here too? it's not as useful, but the consistency might be worth it.

[gri, 2012-09-11 04:17:10]

Fine w/ me but let r weigh in - he also has a eye for type setting.
- gri

Please update the date in the beginning and change the CL from "doc: ...." to
"spec: ...".

http://codereview.appspot.com/6498115/diff/4001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/6498115/diff/4001/doc/go_spec.html#newcode2921
doc/go_spec.html:2921: &    bitwise AND            integers
No strong feelings but alternatively, consider <i>and</i>, etc. which looks a
bit nicer in my mind. This is the approach taken in Warren's Hacker's Delight
(see page 3, Notation).

http://codereview.appspot.com/6498115/diff/4001/doc/go_spec.html#newcode3185
doc/go_spec.html:3185: &amp;&amp;    conditional and    p &amp;&amp; q  is  "if
p then q else false"
On 2012/09/11 03:11:09, dsymonds wrote:
> down here too? it's not as useful, but the consistency might be worth it.

agreed.

[r, 2012-09-11 05:12:17]

LGTM after updating the other location

AND (as written here) is the preferred style in my book.

[rsc, 2012-09-11 16:39:11]

Hello gri@golang.org, dsymonds@golang.org, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[gri, 2012-09-11 17:08:00]

LGTM

The CL still refers to "doc:" (which doc?) rather than "spec:".

http://codereview.appspot.com/6498115/diff/6003/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/6498115/diff/6003/doc/go_spec.html#newcode3
doc/go_spec.html:3: "Subtitle": "Version of September 7, 2012",
up-date

[rsc, 2012-09-12 16:05:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=a4ab112f5b8f ***

spec: make bitwise operators stand out

The (and not) arguably sounds like it is trying to say something - and not
what?.

Just an idea, won't be hurt if it gets rejected.

R=gri, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/6498115