Issue 6496099: code review 6496099: crypto/rand: zero length reads shouldn't crash on Windows.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6496099: code review 6496099: crypto/rand: zero length reads shouldn't crash on Windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by agl1

Modified:
11 years, 7 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Description

crypto/rand: zero length reads shouldn't crash on Windows.

Patch Set 2 : diff -r ac1b735e8753 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ac1b735e8753 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9f6681feef6d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 9f6681feef6d https://go.googlecode.com/hg/ #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	src/pkg/crypto/rand/rand_test.go	View	1 2 3	1 chunk	+11 lines, -0 lines	1 comment	Download
	M	src/pkg/crypto/rand/rand_windows.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2012-09-09 23:58:43 UTC) #1

dave_cheney.net

LGTM. Please steal the test from this CL http://codereview.appspot.com/6497105

11 years, 7 months ago (2012-09-10 00:01:18 UTC) #2

dave_cheney.net

https://codereview.appspot.com/6496099/diff/11001/src/pkg/crypto/rand/rand_test.go File src/pkg/crypto/rand/rand_test.go (right): https://codereview.appspot.com/6496099/diff/11001/src/pkg/crypto/rand/rand_test.go#newcode41 src/pkg/crypto/rand/rand_test.go:41: t.Fatalf("Read(make(nil) = %d, %v", n, err) Read(nil) = ...

11 years, 7 months ago (2012-09-10 00:07:48 UTC) #4

agl1

11 years, 7 months ago (2012-09-10 00:09:54 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=a69e30463bf4 ***

crypto/rand: zero length reads shouldn't crash on Windows.

R=golang-dev, dave
CC=golang-dev
http://codereview.appspot.com/6496099

Expand All Messages | Collapse All Messages