Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2080)

Issue 6495121: code review 6495121: net/rpc/jsonrpc: fix test error message (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by rsc
Modified:
11 years, 6 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net/rpc/jsonrpc: fix test error message Fixes issue 4041.

Patch Set 1 #

Patch Set 2 : diff -r 56f5a223dcd7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 56f5a223dcd7 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 56f5a223dcd7 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/pkg/net/rpc/jsonrpc/all_test.go View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 6 months ago (2012-09-12 21:28:31 UTC) #1
bradfitz
LGTM but... https://codereview.appspot.com/6495121/diff/3/src/pkg/net/rpc/jsonrpc/all_test.go File src/pkg/net/rpc/jsonrpc/all_test.go (right): https://codereview.appspot.com/6495121/diff/3/src/pkg/net/rpc/jsonrpc/all_test.go#newcode131 src/pkg/net/rpc/jsonrpc/all_test.go:131: t.Errorf("Add: expected no error but got string ...
11 years, 6 months ago (2012-09-12 21:34:49 UTC) #2
rsc
11 years, 6 months ago (2012-09-12 21:37:42 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=cbce1b576493 ***

net/rpc/jsonrpc: fix test error message

Fixes issue 4041.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6495121

http://codereview.appspot.com/6495121/diff/3/src/pkg/net/rpc/jsonrpc/all_test.go
File src/pkg/net/rpc/jsonrpc/all_test.go (right):

http://codereview.appspot.com/6495121/diff/3/src/pkg/net/rpc/jsonrpc/all_test...
src/pkg/net/rpc/jsonrpc/all_test.go:131: t.Errorf("Add: expected no error but
got string %q", err.Error())
On 2012/09/12 21:34:49, bradfitz wrote:
> err.Error() can crash if err is nil.  just want "err" here instead?

Whoops, didn't undo enough. Reverting that line. Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b