Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84)

Issue 6493071: code review 6493071: doc css: topbar sticks to the top of large windows.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by skybrian1
Modified:
12 years, 5 months ago
Reviewers:
skybrian, DMorsing, adg
CC:
adg, gobot, golang-dev
Visibility:
Public.

Description

doc css: topbar sticks to the top of large windows. Rationale: for large screens, the convenience of not having to scroll to the top of the page to do a search outweighs having less vertical space. Tested with Chrome, Firefox, Safari with various window and text sizes.

Patch Set 1 #

Patch Set 2 : diff -r 272e1dd72156 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 272e1dd72156 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 272e1dd72156 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M doc/style.css View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6
skybrian1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 6 months ago (2012-09-03 02:46:59 UTC) #1
gobot
R=adg (assigned by rsc)
12 years, 6 months ago (2012-09-10 15:41:14 UTC) #2
adg
LGTM Nice change.
12 years, 6 months ago (2012-09-11 01:24:13 UTC) #3
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=56c7453d488f *** doc css: topbar sticks to the top of large windows. ...
12 years, 6 months ago (2012-09-11 01:38:50 UTC) #4
skybrian
When should I expect this change to appear on golang.org? On Monday, September 10, 2012 ...
12 years, 5 months ago (2012-09-30 19:06:38 UTC) #5
DMorsing
12 years, 5 months ago (2012-09-30 20:32:15 UTC) #6
On Sun, Sep 30, 2012 at 9:06 PM,  <bslesinsky@gmail.com> wrote:
> When should I expect this change to appear on golang.org?
>

This change was reverted by https://codereview.appspot.com/6488121/
because it didn't handle anchor links well.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b