Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(361)

Issue 6490091: code review 6490091: spec: BOMs can be ignored everywhere (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by r
Modified:
12 years, 6 months ago
Reviewers:
CC:
golang-dev, rsc, 0xjnml, gri, bradfitz
Visibility:
Public.

Description

spec: an initial BOM can be ignored After further deliberation, let's back down to the Unicode proposal. Ignoring aBOMinations anywhere means that things like grep unsafe *.go might fail because there's a BOM in the middle: unBOMsafe.

Patch Set 1 #

Patch Set 2 : diff -r c99aad44d76c https://code.google.com/p/go #

Patch Set 3 : diff -r 3da1d25fd216 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M doc/go_spec.html View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 6 months ago (2012-09-07 16:10:52 UTC) #1
rsc
It bothers me that 'grep unsafe *.go' might fail because it has been written un<BOM>safe. ...
12 years, 6 months ago (2012-09-07 16:22:46 UTC) #2
0xjnml
I'm with Russ on this one. -j
12 years, 6 months ago (2012-09-07 16:27:25 UTC) #3
r
We're about to visit the last unvisited point in the design space for these little ...
12 years, 6 months ago (2012-09-07 16:33:11 UTC) #4
gri
On 2012/09/07 16:33:11, r wrote: > We're about to visit the last unvisited point in ...
12 years, 6 months ago (2012-09-07 16:40:48 UTC) #5
bradfitz
Only because you're soliciting votes: I also think BOM only at beginning of file or ...
12 years, 6 months ago (2012-09-07 16:41:12 UTC) #6
r
It's the "for now" part that bugs me. I'd prefer "forever". -rob
12 years, 6 months ago (2012-09-07 16:50:02 UTC) #7
r
Hello golang-dev@googlegroups.com, rsc@golang.org, 0xjnml@gmail.com, gri@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 6 months ago (2012-09-07 17:08:31 UTC) #8
0xjnml
Works for me, AFAICS. -j
12 years, 6 months ago (2012-09-07 17:14:18 UTC) #9
gri
LGTM
12 years, 6 months ago (2012-09-07 17:24:59 UTC) #10
rsc
LGTM but update the description.
12 years, 6 months ago (2012-09-07 17:26:45 UTC) #11
remyoudompheng
LGTM
12 years, 6 months ago (2012-09-07 17:28:02 UTC) #12
r
12 years, 6 months ago (2012-09-07 17:28:27 UTC) #13
*** Submitted as http://code.google.com/p/go/source/detail?r=6887692cc272 ***

spec: an initial BOM can be ignored
After further deliberation, let's back down to the Unicode proposal.
Ignoring aBOMinations anywhere means that things like
        grep unsafe *.go
might fail because there's a BOM in the middle: unBOMsafe.

R=golang-dev, rsc, 0xjnml, gri, bradfitz
CC=golang-dev
http://codereview.appspot.com/6490091
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b