Issue 6488121: code review 6488121: undo CL 6493071 / 56c7453d488f

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6488121: code review 6488121: undo CL 6493071 / 56c7453d488f (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by adg

Modified:
12 years, 6 months ago

Reviewers:

CC:
golang-dev, r, dsymonds

Visibility:
Public.

Description

undo CL 6493071 / 56c7453d488f This change messes with anchor links. It obscures the item being linked to. I don't see a way around it. Undoing for now. Fixes issue 4071. ««« original CL description doc css: topbar sticks to the top of large windows. Rationale: for large screens, the convenience of not having to scroll to the top of the page to do a search outweighs having less vertical space. Tested with Chrome, Firefox, Safari with various window and text sizes. R=adg CC=gobot, golang-dev http://codereview.appspot.com/6493071 Committer: Andrew Gerrand <adg@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r cbce1b576493 https://go.googlecode.com/hg #

Patch Set 3 : diff -r cbce1b576493 https://go.googlecode.com/hg #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -18 lines)			Patch
	M	doc/style.css	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years, 6 months ago (2012-09-13 00:46:47 UTC) #1

Why does it say "I'd like you to review this change to https://go.googlecode.com/hg"? That's not ...

12 years, 6 months ago (2012-09-13 00:52:24 UTC) #2

adg

Its the old style URL but it still works. It betrays the age of my ...

12 years, 6 months ago (2012-09-13 00:55:15 UTC) #3

adg

12 years, 6 months ago (2012-09-13 01:14:30 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=b3c1f7e35083 ***

      undo CL 6493071 / 56c7453d488f

This change messes with anchor links. It obscures the item being linked to.
I don't see a way around it. Undoing for now.

      Fixes issue 4071.

      ««« original CL description
      doc css: topbar sticks to the top of large windows.
      Rationale: for large screens, the convenience of not having to scroll
      to the top of the page to do a search outweighs having less vertical
      space.
      Tested with Chrome, Firefox, Safari with various window and text sizes.

      R=adg
      CC=gobot, golang-dev
      http://codereview.appspot.com/6493071

      Committer: Andrew Gerrand <adg@golang.org>
      »»»

R=golang-dev, r, dsymonds
CC=golang-dev
http://codereview.appspot.com/6488121

Expand All Messages | Collapse All Messages