code review 6488120: effective_go: use html/template instead of text/template

effective_go: use html/template instead of text/template
Should have done this a long time ago.
Fixes issue 3811.

[r, 2012-09-12 19:55:23]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2012-09-12 23:56:55]

LGTM

http://codereview.appspot.com/6488120/diff/1/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/6488120/diff/1/doc/effective_go.html#newcode3008
doc/effective_go.html:3008: The two snippets <code>{{html "{{.}}"}}</code> say
to show the data presented to
is the "html" function necessary? I don't see why.

http://codereview.appspot.com/6488120/diff/1/doc/effective_go.html#newcode3009
doc/effective_go.html:3009: the template—the query string—on the web page.
use &mdash; -- this confused me.

[r, 2012-09-13 00:04:28]

http://codereview.appspot.com/6488120/diff/1/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/6488120/diff/1/doc/effective_go.html#newcode3008
doc/effective_go.html:3008: The two snippets <code>{{html "{{.}}"}}</code> say
to show the data presented to
On 2012/09/12 23:56:55, adg wrote:
> is the "html" function necessary? I don't see why.

it's not wrong. is it a problem? this way i don't have to think about whether
the braces need quoting.

[adg, 2012-09-13 00:08:43]

On 13 September 2012 10:04,  <r@golang.org> wrote:
>
> http://codereview.appspot.com/6488120/diff/1/doc/effective_go.html
> File doc/effective_go.html (right):
>
>
http://codereview.appspot.com/6488120/diff/1/doc/effective_go.html#newcode3008
> doc/effective_go.html:3008: The two snippets <code>{{html
> "{{.}}"}}</code> say to show the data presented to
> On 2012/09/12 23:56:55, adg wrote:
>>
>> is the "html" function necessary? I don't see why.
>
>
> it's not wrong. is it a problem? this way i don't have to think about
> whether the braces need quoting.

Doesn't godoc use html/template? Should we need to worry at all?

[r, 2012-09-13 00:14:58]

On Wed, Sep 12, 2012 at 5:08 PM, Andrew Gerrand <adg@golang.org> wrote:
> Doesn't godoc use html/template? Should we need to worry at all?

It does not.

-rob

[rsc, 2012-09-13 03:06:56]

LGTM

The Unicode em dash looks fine to me.

[r, 2012-09-13 20:41:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=e3fce06291ec ***

effective_go: use html/template instead of text/template
Should have done this a long time ago.
Fixes issue 3811.

R=golang-dev, adg, rsc
CC=golang-dev
http://codereview.appspot.com/6488120

[r, 2012-09-13 20:42:21]

adg, regarding em dash: they're already used in that style in the
document. given the other non-ASCII characters in the file, it seems
reasonable to accept these.

-rob

[rsc, 2012-09-13 20:43:58]

On Thu, Sep 13, 2012 at 4:42 PM, Rob Pike <r@golang.org> wrote:
> adg, regarding em dash: they're already used in that style in the
> document. given the other non-ASCII characters in the file, it seems
> reasonable to accept these.

fwiw i believe the confusion is because at least on my mac rietveld's
fixed-width font makes em dashes look like en dashes. but if you use a
real font in a real editor all is well.

[adg, 2012-09-13 22:53:12]

On 14 September 2012 06:43, Russ Cox <rsc@golang.org> wrote:
> On Thu, Sep 13, 2012 at 4:42 PM, Rob Pike <r@golang.org> wrote:
>> adg, regarding em dash: they're already used in that style in the
>> document. given the other non-ASCII characters in the file, it seems
>> reasonable to accept these.
>
> fwiw i believe the confusion is because at least on my mac rietveld's
> fixed-width font makes em dashes look like en dashes. but if you use a
> real font in a real editor all is well.

That's precisely what was happening for me. Looks fine in godoc proper.

Andrew