Issue 6461047: code review 6461047: math: update definition of NaN in assembly language files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6461047: code review 6461047: math: update definition of NaN in assembly language files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by Charlie Dorian

Modified:
12 years, 7 months ago

Reviewers:

CC:
rsc, minux1, golang-dev, nigeltao

Visibility:
Public.

Description

math: update definition of NaN in assembly language files

Patch Set 1 #

Patch Set 2 : diff -r c37d3a28f6b0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c37d3a28f6b0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c37d3a28f6b0 https://go.googlecode.com/hg/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	src/pkg/math/dim_amd64.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/hypot_386.s	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/hypot_amd64.s	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/log_amd64.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/sincos_amd64.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

Charlie Dorian

Hello rsc@golang.org, minux.ma@gmail.com, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 7 months ago (2012-08-07 05:15:52 UTC) #1

minux1

I wonder why we doesn't split these definitions into a separate header file?

12 years, 7 months ago (2012-08-07 05:36:35 UTC) #3

minux1

On Tue, Aug 7, 2012 at 1:36 PM, <minux.ma@gmail.com> wrote: > I wonder why we ...

12 years, 7 months ago (2012-08-07 05:37:45 UTC) #4

Charlie Dorian

Yes. On Tue, Aug 7, 2012 at 1:39 AM, <nigeltao@golang.org> wrote: > Should hypot_386.s also ...

12 years, 7 months ago (2012-08-07 05:46:47 UTC) #6

Charlie Dorian

Hello rsc@golang.org, minux.ma@gmail.com, golang-dev@googlegroups.com, nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 7 months ago (2012-08-07 05:51:39 UTC) #7

nigeltao

12 years, 7 months ago (2012-08-08 23:40:29 UTC) #9

*** Submitted as http://code.google.com/p/go/source/detail?r=f26c1758e269 ***

math: update definition of NaN in assembly language files

R=rsc, minux.ma, golang-dev, nigeltao
CC=golang-dev
http://codereview.appspot.com/6461047

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages