Issue 6461046: code review 6461046: net/http: disable TestServeFileFromCWD test on windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6461046: code review 6461046: net/http: disable TestServeFileFromCWD test on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by brainman

Modified:
11 years, 8 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

net/http: disable TestServeFileFromCWD test on windows This is an attempt to fix windows build. Will restore once we know what the problem is.

Patch Set 2 : diff -r 372286d59a57 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 372286d59a57 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 4adee56240ac https://go.googlecode.com/hg/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/pkg/net/http/fs_test.go	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 8 months ago (2012-08-07 02:56:17 UTC) #1

bradfitz

LGTM with change below http://codereview.appspot.com/6461046/diff/3/src/pkg/net/http/fs_test.go File src/pkg/net/http/fs_test.go (right): http://codereview.appspot.com/6461046/diff/3/src/pkg/net/http/fs_test.go#newcode345 src/pkg/net/http/fs_test.go:345: t.Logf("skipping; it breaks build") t.Logf("Temporarily ...

11 years, 8 months ago (2012-08-07 03:01:48 UTC) #2

brainman

11 years, 8 months ago (2012-08-07 03:19:56 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a834a940704c ***

net/http: disable TestServeFileFromCWD test on windows

This is an attempt to fix windows build. Will restore
once we know what the problem is.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6461046

http://codereview.appspot.com/6461046/diff/3/src/pkg/net/http/fs_test.go
File src/pkg/net/http/fs_test.go (right):

http://codereview.appspot.com/6461046/diff/3/src/pkg/net/http/fs_test.go#newc...
src/pkg/net/http/fs_test.go:345: t.Logf("skipping; it breaks build")
On 2012/08/07 03:01:48, bradfitz wrote:
> t.Logf("Temporarily skipping test on Windows; see
http://golang.org/issue/3917%22)

Done.

Expand All Messages | Collapse All Messages