Issue 6459055: code review 6459055: proxy: fix wrong function name in comment

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6459055: code review 6459055: proxy: fix wrong function name in comment (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by agl1

Modified:
12 years, 7 months ago

Reviewers:

CC:
golang-dev, minux1

Visibility:
Public.

Description

proxy: fix wrong function name in comment

Patch Set 2 : diff -r d7d24fafd03c https://agl%40golang.org@code.google.com/p/go.net/ #

Patch Set 3 : diff -r d7d24fafd03c https://agl%40golang.org@code.google.com/p/go.net/ #

Total comments: 2

Patch Set 4 : diff -r d7d24fafd03c https://agl%40golang.org@code.google.com/p/go.net/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	proxy/per_host.go	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://agl%40golang.org@code.google.com/p/go.net/

12 years, 7 months ago (2012-08-07 16:04:37 UTC) #1

minux1

also: comment in line 27 of proxy.go is wrong. http://codereview.appspot.com/6459055/diff/1002/proxy/per_host.go File proxy/per_host.go (right): http://codereview.appspot.com/6459055/diff/1002/proxy/per_host.go#newcode35 proxy/per_host.go:35: ...

12 years, 7 months ago (2012-08-07 16:11:36 UTC) #2

agl1

12 years, 7 months ago (2012-08-14 01:29:10 UTC) #3

*** Submitted as
http://code.google.com/p/go/source/detail?r=147c4a6dca9b&repo=net ***

proxy: fix wrong function name in comment

R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6459055

http://codereview.appspot.com/6459055/diff/1002/proxy/per_host.go
File proxy/per_host.go (right):

http://codereview.appspot.com/6459055/diff/1002/proxy/per_host.go#newcode35
proxy/per_host.go:35: func (p *PerHost) Dial(network, addr string) (c net.Conn,
err error) {
On 2012/08/07 16:11:36, minux wrote:
> i think this comment mentions network "net", but the code uses "networks".
> should this be made consistent?

Done.

Expand All Messages | Collapse All Messages