code review 6454131: exp/html: discard tags that are terminated by EOF inste...

exp/html: discard tags that are terminated by EOF instead of by '>'

If a tag doesn't have a closing '>', it isn't considered a tag;
it is just ignored and EOF is returned instead.

Pass one additional test in the test suite.

Change tokenizer tests to match correct behavior.

[andybalholm, 2012-08-10 15:35:32]

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[nigeltao, 2012-08-13 02:06:48]

LGTM.

Huh. I'm pretty sure that, when the token tests were first written, they matched
html5lib's tokenization. I guess that html5lib's behavior has changed since
then.

Submitting...

http://codereview.appspot.com/6454131/diff/4001/src/pkg/exp/html/token.go
File src/pkg/exp/html/token.go (right):

http://codereview.appspot.com/6454131/diff/4001/src/pkg/exp/html/token.go#new...
src/pkg/exp/html/token.go:951: if z.err == nil {
I'd compare !=.

[nigeltao, 2012-08-13 02:08:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=b855390a295f ***

exp/html: discard tags that are terminated by EOF instead of by '>'

If a tag doesn't have a closing '>', it isn't considered a tag;
it is just ignored and EOF is returned instead.

Pass one additional test in the test suite.

Change tokenizer tests to match correct behavior.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/6454131

Committer: Nigel Tao <nigeltao@golang.org>