code review 6454089: go/ast: ast.Print must not crash with unexported fields

go/ast: ast.Print must not crash with unexported fields

Don't print unexported struct fields; their values are
not accessible via reflection.

Fixes issue 3898.

Also:
- added support for arrays
- print empty maps, arrays, slices, structs on one line
  for a denser output
- added respective test cases

[gri, 2012-08-02 22:40:40]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[r, 2012-08-02 23:47:38]

LGTM

http://codereview.appspot.com/6454089/diff/4001/src/pkg/go/ast/print.go
File src/pkg/go/ast/print.go (right):

http://codereview.appspot.com/6454089/diff/4001/src/pkg/go/ast/print.go#newco...
src/pkg/go/ast/print.go:216: if name := t.Field(i).Name; IsExported(name) {
i'd use a continue here to reduce the indentation by 1 but it's fine like this.

[gri, 2012-08-03 00:06:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=d134e30c4d29 ***

go/ast: ast.Print must not crash with unexported fields

Don't print unexported struct fields; their values are
not accessible via reflection.

Fixes issue 3898.

Also:
- added support for arrays
- print empty maps, arrays, slices, structs on one line
  for a denser output
- added respective test cases

R=r
CC=golang-dev
http://codereview.appspot.com/6454089