Issue 6453105: code review 6453105: text/template/parse: fix bug handling /*/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6453105: code review 6453105: text/template/parse: fix bug handling /*/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by r

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

text/template/parse: fix bug handling /*/ Incorrect syntax for comment was erroneously accepted. Fixes issue 3919.

Patch Set 1 #

Patch Set 2 : diff -r 3532ab6bf5be https://code.google.com/p/go/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	src/pkg/text/template/parse/lex.go	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	src/pkg/text/template/parse/lex_test.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 8 months ago (2012-08-09 17:28:05 UTC) #1

12 years, 8 months ago (2012-08-10 02:24:50 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=62f087306b18 ***

text/template/parse: fix bug handling /*/
Incorrect syntax for comment was erroneously accepted.
Fixes issue 3919.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6453105

Expand All Messages | Collapse All Messages