code review 64520043: go.tools/dashboard/builder: use $home on Plan 9

go.tools/dashboard/builder: use $home on Plan 9

[0intro, 2014-02-16 09:37:25]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[lucio, 2014-02-16 09:54:53]

Looks good.  Thanks for finding all these little things.

Lucio.


On 2/16/14, 0intro@gmail.com <0intro@gmail.com> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> go.tools/dashboard/builder: use $home on Plan 9
>
> Please review this at https://codereview.appspot.com/64520043/
>
> Affected files (+5, -2 lines):
>    M dashboard/builder/main.go
>
>
> Index: dashboard/builder/main.go
> ===================================================================
> --- a/dashboard/builder/main.go
> +++ b/dashboard/builder/main.go
> @@ -203,9 +203,12 @@
>
>   	// read keys from keyfile
>   	fn := ""
> -	if runtime.GOOS == "windows" {
> +	switch runtime.GOOS {
> +	case "plan9":
> +		fn = os.Getenv("home")
> +	case "windows":
>   		fn = os.Getenv("HOMEDRIVE") + os.Getenv("HOMEPATH")
> -	} else {
> +	default:
>   		fn = os.Getenv("HOME")
>   	}
>   	fn = filepath.Join(fn, ".gobuildkey")
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[brainman, 2014-02-16 12:05:54]

LGTM

[0intro, 2014-02-16 16:41:08]

*** Submitted as
https://code.google.com/p/go/source/detail?r=460154e4868c&repo=tools ***

go.tools/dashboard/builder: use $home on Plan 9

LGTM=alex.brainman
R=golang-codereviews, lucio.dere, alex.brainman
CC=golang-codereviews
https://codereview.appspot.com/64520043