Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1461)

Issue 6449105: code review 6449105: godoc: make id attributes unique (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by gri
Modified:
12 years, 8 months ago
Reviewers:
CC:
adg, dsymonds, golang-dev
Visibility:
Public.

Description

godoc: make id attributes unique Some browsers (e.g. IE9) ignore the case of 'id' attributes which can lead to conflicts. Prefix non-generated 'id's with "pkg-" to make them different from any generated attribute. Also: Added missing entry for "Other packages" to top-level index. Fixes issue 3851.

Patch Set 1 #

Patch Set 2 : diff -r d3dd48c73d6d https://code.google.com/p/go #

Patch Set 3 : diff -r d3dd48c73d6d https://code.google.com/p/go #

Patch Set 4 : diff -r d3dd48c73d6d https://code.google.com/p/go #

Patch Set 5 : diff -r d3dd48c73d6d https://code.google.com/p/go #

Patch Set 6 : diff -r d3dd48c73d6d https://code.google.com/p/go #

Patch Set 7 : diff -r d3dd48c73d6d https://code.google.com/p/go #

Patch Set 8 : diff -r b562c975ab22 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M lib/godoc/package.html View 1 2 3 4 5 8 chunks +24 lines, -15 lines 0 comments Download

Messages

Total messages: 9
gri
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 8 months ago (2012-08-07 20:15:55 UTC) #1
dsymonds
LGTM
12 years, 8 months ago (2012-08-07 23:44:47 UTC) #2
adg
NOT LGTM Some browsers don't like underscores in ids.
12 years, 8 months ago (2012-08-08 00:09:36 UTC) #3
gri
Hello adg@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 8 months ago (2012-08-08 00:30:54 UTC) #4
dsymonds
Per http://www.w3schools.com/tags/att_standard_id.asp, id attributes * Must begin with a letter A-Z or a-z * Can ...
12 years, 8 months ago (2012-08-08 00:33:21 UTC) #5
adg
+1 for "toc-" or "godoc-"
12 years, 8 months ago (2012-08-08 00:37:50 UTC) #6
gri
Hello adg@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 8 months ago (2012-08-08 00:42:27 UTC) #7
adg
LGTM
12 years, 8 months ago (2012-08-08 00:44:32 UTC) #8
gri
12 years, 8 months ago (2012-08-08 00:46:03 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=b5dd89dce002 ***

godoc: make id attributes unique

Some browsers (e.g. IE9) ignore the case of 'id' attributes
which can lead to conflicts. Prefix non-generated 'id's with
"pkg-" to make them different from any generated attribute.

Also: Added missing entry for "Other packages" to top-level
index.

Fixes issue 3851.

R=adg, dsymonds
CC=golang-dev
http://codereview.appspot.com/6449105
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b