Issue 6448137: code review 6448137: go_spec.html: clarify rune and string literals

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6448137: code review 6448137: go_spec.html: clarify rune and string literals (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by r

Modified:
12 years, 6 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

go_spec.html: clarify rune and string literals No changes to the meaning, just clearer language and more examples, including illegal rune and string literals. In particular, "character literal" and "character constant" are now called "rune literal" and "rune constant" and the word "character" always refers to the source text, not program values.

Patch Set 1 #

Patch Set 2 : diff -r 307fafbc2d6f https://code.google.com/p/go #

Patch Set 3 : diff -r 307fafbc2d6f https://code.google.com/p/go #

Patch Set 4 : diff -r 8f0c8f604ee0 https://code.google.com/p/go #

Total comments: 4

Patch Set 5 : diff -r 008d345d81e0 https://code.google.com/p/go #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -28 lines)			Patch
	M	doc/go_spec.html	View	1 2 3 4	19 chunks	+39 lines, -28 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 7 months ago (2012-08-10 18:46:50 UTC) #1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 6 months ago (2012-08-17 20:04:05 UTC) #2

CL now reads: go_spec.html: clarify rune and string literals No changes to the meaning, just ...

12 years, 6 months ago (2012-08-17 20:04:28 UTC) #3

gri

LGTM w/ some minor nitpicks http://codereview.appspot.com/6448137/diff/6001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6448137/diff/6001/doc/go_spec.html#newcode3 doc/go_spec.html:3: "Subtitle": "Version of August ...

12 years, 6 months ago (2012-08-29 21:33:57 UTC) #4

12 years, 6 months ago (2012-08-29 21:47:03 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=8afe25accb81 ***

go_spec.html: clarify rune and string literals
No changes to the meaning, just clearer language and more
examples, including illegal rune and string literals.
In particular, "character literal" and "character constant"
are now called "rune literal" and "rune constant" and the
word "character" always refers to the source text, not
program values.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/6448137

Expand All Messages | Collapse All Messages