Issue 6446084: code review 6446084: exp/types: add more import tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6446084: code review 6446084: exp/types: add more import tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by gri

Modified:
12 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

exp/types: add more import tests Also simplified parsing of interface types since they can only contain methods (and no embedded interfaces) in the export data.

Patch Set 1 #

Patch Set 2 : diff -r 146c8378f3cc https://code.google.com/p/go #

Patch Set 3 : diff -r 146c8378f3cc https://code.google.com/p/go #

Patch Set 4 : diff -r 146c8378f3cc https://code.google.com/p/go #

Patch Set 5 : diff -r 146c8378f3cc https://code.google.com/p/go #

Patch Set 6 : diff -r 422b4a8160bc https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 422b4a8160bc https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 422b4a8160bc https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 6beada1bf6c2 https://code.google.com/p/go #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -22 lines)			Patch
	M	src/pkg/exp/types/gcimporter.go	View	1 2 3 4 5	1 chunk	+9 lines, -21 lines	0 comments	Download
	M	src/pkg/exp/types/gcimporter_test.go	View	1 2 3 4	2 chunks	+40 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 7 months ago (2012-08-04 00:03:19 UTC) #1

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 7 months ago (2012-08-04 04:07:08 UTC) #2

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 7 months ago (2012-08-04 04:19:40 UTC) #4

gri

12 years, 7 months ago (2012-08-09 18:55:05 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=f979026319cc ***

exp/types: add more import tests

Also simplified parsing of interface
types since they can only contain
methods (and no embedded interfaces)
in the export data.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6446084

Expand All Messages | Collapse All Messages