Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 6445092: code review 6445092: testing: add Verbose() to expose whether -test.v is set (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by minux1
Modified:
12 years, 7 months ago
Reviewers:
mtj1
CC:
golang-dev, adg, r, albert.strasheim
Visibility:
Public.

Description

testing: add Verbose() to expose whether -test.v is set Fixes issue 3350.

Patch Set 1 #

Patch Set 2 : diff -r 87e3318f6a52 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0934e2afdec9 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/pkg/testing/testing.go View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 7 months ago (2012-08-09 07:28:54 UTC) #1
adg
LGTM but wait for r before submitting
12 years, 7 months ago (2012-08-09 07:34:46 UTC) #2
albert.strasheim
This fixes issue 3350. Thanks. http://code.google.com/p/go/issues/detail?id=3350
12 years, 7 months ago (2012-08-09 07:58:58 UTC) #3
minux1
On 2012/08/09 07:58:58, albert.strasheim wrote: > This fixes issue 3350. cl description updated, thanks for ...
12 years, 7 months ago (2012-08-09 08:56:37 UTC) #4
r
LGTM
12 years, 7 months ago (2012-08-09 14:53:33 UTC) #5
minux1
*** Submitted as http://code.google.com/p/go/source/detail?r=9ef259879f24 *** testing: add Verbose() to expose whether -test.v is set Fixes ...
12 years, 7 months ago (2012-08-09 15:41:21 UTC) #6
mtj1
12 years, 7 months ago (2012-08-09 16:27:02 UTC) #7
Thanks, all!

On Thu, Aug 9, 2012 at 8:41 AM,  <minux.ma@gmail.com> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=9ef259879f24 ***
>
>
> testing: add Verbose() to expose whether -test.v is set
>     Fixes issue 3350.
>
> R=golang-dev, adg, r, fullung
> CC=golang-dev
> http://codereview.appspot.com/6445092
>
>
> http://codereview.appspot.com/6445092/



-- 
Michael T. Jones | Chief Technology Advocate  | mtj@google.com |  +1
650-335-5765
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b