Issue 6444049: code review 6444049: cmd/cgo: use 1 as last entry for __cgodebug_data

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6444049: code review 6444049: cmd/cgo: use 1 as last entry for __cgodebug_data (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by minux1

Modified:
11 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/cgo: use 1 as last entry for __cgodebug_data LLVM-based gcc will place all-zero data in a zero-filled section, but our debug/macho can't handle that. Fixes issue 3821.

Patch Set 1 #

Patch Set 2 : diff -r 6751a0e1a6a4 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6751a0e1a6a4 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6751a0e1a6a4 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 235bd4eb543e https://code.google.com/p/go/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/cmd/cgo/gcc.go	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 9 months ago (2012-07-25 22:40:25 UTC) #1

minux1

11 years, 9 months ago (2012-07-30 22:45:15 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=aeaab9df5600 ***

cmd/cgo: use 1 as last entry for __cgodebug_data
        LLVM-based gcc will place all-zero data in a zero-filled
        section, but our debug/macho can't handle that.
        Fixes issue 3821.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6444049

Expand All Messages | Collapse All Messages