code review 6443110: test: use run.go for more tests.

test: use run.go for more tests.

[remyoudompheng, 2012-08-10 06:18:30]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[remyoudompheng, 2012-08-10 06:19:59]

Essentially renaming compiledir targets to have them ordered. I am not sure
about bug206.out on Windows, maybe CL 5847068 is necessary for it?

[brainman, 2012-08-10 07:20:49]

On 2012/08/10 06:19:59, remyoudompheng wrote:
> ... I am not sure
> about bug206.out on Windows, maybe CL 5847068 is necessary for it?

I think you will be OK on windows, because we output to console as is. I think
CL 5847068 is different because their program calls into C console output
function. Perhaps, these do line end character fiddling.

Alex

[minux1, 2012-08-10 07:34:16]

http://codereview.appspot.com/6443110/diff/7001/test/fixedbugs/bug206.go
File test/fixedbugs/bug206.go (right):

http://codereview.appspot.com/6443110/diff/7001/test/fixedbugs/bug206.go#newc...
test/fixedbugs/bug206.go:1: // run
better to be explicit and use cmpout?

http://codereview.appspot.com/6443110/diff/7001/test/fixedbugs/bug335.go
File test/fixedbugs/bug335.go (right):

http://codereview.appspot.com/6443110/diff/7001/test/fixedbugs/bug335.go#newc...
test/fixedbugs/bug335.go:9: unused (see script at top of file)
update this to be consistent?
package ignored

[remyoudompheng, 2012-08-11 07:54:34]

Hello golang-dev@googlegroups.com, alex.brainman@gmail.com, minux.ma@gmail.com
(cc: golang-dev@googlegroups.com),

Please take another look.

[remyoudompheng, 2012-08-25 07:19:40]

ping?

[minux1, 2012-08-25 07:58:37]

LGTM.

[remyoudompheng, 2012-08-25 08:16:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=9e610a78455c ***

test: use run.go for more tests.

R=golang-dev, alex.brainman, minux.ma
CC=golang-dev
http://codereview.appspot.com/6443110