code review 6442087: bufio: discourage use of ReadLine

bufio: discourage use of ReadLine

Too many people use it without reading what it does.
Those people want ReadBytes or ReadString.

Fixes issue 3906.

[rsc, 2012-08-05 16:51:39]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[iant2, 2012-08-05 17:07:52]

LGTM

On Sun, Aug 5, 2012 at 9:51 AM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> bufio: discourage use of ReadLine
>
> Too many people use it without reading what it does.
> Those people want ReadBytes or ReadString.
>
> Fixes issue 3906.
>
> Please review this at http://codereview.appspot.com/6442087/
>
> Affected files:
>   M src/pkg/bufio/bufio.go
>
>
> Index: src/pkg/bufio/bufio.go
> ===================================================================
> --- a/src/pkg/bufio/bufio.go
> +++ b/src/pkg/bufio/bufio.go
> @@ -272,6 +272,9 @@
>         panic("not reached")
>  }
>
> +// ReadLine is a low-level line-reading primitive. Most callers should use
> +// ReadBytes('\n') or ReadString('\n') instead.
> +//
>  // ReadLine tries to return a single line, not including the end-of-line
> bytes.
>  // If the line was too long for the buffer then isPrefix is set and the
>  // beginning of the line is returned. The rest of the line will be returned
>
>

[r, 2012-08-05 17:34:25]

LGTM

[rsc, 2012-08-05 18:32:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=9e2011d9ed4b ***

bufio: discourage use of ReadLine

Too many people use it without reading what it does.
Those people want ReadBytes or ReadString.

Fixes issue 3906.

R=golang-dev, iant, r
CC=golang-dev
http://codereview.appspot.com/6442087