Issue 6442061: code review 6442061: net/http: don't allow zero byte in FileServer paths

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6442061: code review 6442061: net/http: don't allow zero byte in FileServer paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bradfitz

Modified:
11 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net/http: don't allow zero byte in FileServer paths Should probably be fixed in the syscall package, either additional or instead of this CL. Fixes issue 3842

Patch Set 1 #

Patch Set 2 : diff -r 4aeff61b5401 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4aeff61b5401 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4883e9e65536 https://go.googlecode.com/hg/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	src/pkg/net/http/fs.go	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/pkg/net/http/fs_test.go	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 9 months ago (2012-07-30 02:51:28 UTC) #1

rsc

LGTM Weren't you the one who added strings.Contains? Also the () are unnecessary.

11 years, 9 months ago (2012-07-30 03:47:23 UTC) #2

bradfitz

On Sun, Jul 29, 2012 at 8:47 PM, Russ Cox <rsc@golang.org> wrote: > LGTM > ...

11 years, 9 months ago (2012-07-30 03:50:06 UTC) #3

bradfitz

11 years, 9 months ago (2012-07-30 03:57:38 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=2307a931664e ***

net/http: don't allow zero byte in FileServer paths

Should probably be fixed in the syscall package, either
additional or instead of this CL.

Fixes issue 3842

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6442061

Expand All Messages | Collapse All Messages