Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(646)

Issue 6440048: code review 6440048: test: add a compiledir pattern in run.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by remyoudompheng
Modified:
12 years, 8 months ago
Reviewers:
CC:
rsc, golang-dev, remy_archlinux.org
Visibility:
Public.

Description

test: add a compiledir pattern in run.go The compiledir pattern compiles all files xxx.dir/*.go in lexicographic order (which is assumed to coincide with the topological order of dependencies).

Patch Set 1 #

Patch Set 2 : diff -r c87a4b5ad6d7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c87a4b5ad6d7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8c4b1b7ce761 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 441d5f62e9ff https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M test/fixedbugs/bug088.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug106.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug282.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug306.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug377.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug396.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug404.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug407.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/run.go View 1 3 chunks +22 lines, -1 line 0 comments Download
M test/testlib View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 8 months ago (2012-07-26 05:53:35 UTC) #1
rsc
I like it. Please update test/testlib so that running ./run by hand still works. Thanks.
12 years, 8 months ago (2012-07-30 00:51:01 UTC) #2
remyoudompheng
Hello rsc@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.
12 years, 8 months ago (2012-07-30 07:02:23 UTC) #3
rsc
LGTM
12 years, 8 months ago (2012-07-30 18:24:24 UTC) #4
remyoudompheng
12 years, 8 months ago (2012-07-30 19:12:17 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=36047074c4dd ***

test: add a compiledir pattern in run.go

The compiledir pattern compiles all files xxx.dir/*.go
in lexicographic order (which is assumed to coincide with
the topological order of dependencies).

R=rsc
CC=golang-dev, remy
http://codereview.appspot.com/6440048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b