Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(952)

Issue 64010043: code review 64010043: compress/bzip2: support superfluous Huffman levels. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by agl1
Modified:
10 years, 3 months ago
Reviewers:
r, gobot
CC:
golang-codereviews, r
Visibility:
Public.

Description

compress/bzip2: support superfluous Huffman levels. These should never be found in a bzip2 file but it does appear that there's a buggy encoder that is producing them. Since the official bzip2 handles this case, this change makes the Go code do likewise. With this change, the code produces the same output as the official bzip2 code on the invalid example given in the bug. Fixes issue 7279.

Patch Set 1 #

Patch Set 2 : diff -r 3ac4616250ed https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3ac4616250ed https://code.google.com/p/go/ #

Patch Set 4 : diff -r 727eb606ecd2 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M src/pkg/compress/bzip2/huffman.go View 1 2 1 chunk +31 lines, -1 line 0 comments Download

Messages

Total messages: 4
agl1
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 3 months ago (2014-02-14 17:34:19 UTC) #1
r
LGTM
10 years, 3 months ago (2014-02-14 18:33:55 UTC) #2
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=e567ba9899fb *** compress/bzip2: support superfluous Huffman levels. These should never be found ...
10 years, 3 months ago (2014-02-14 22:17:49 UTC) #3
gobot
10 years, 3 months ago (2014-02-14 22:52:45 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the windows-amd64-race builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b