Issue 63900043: code review 63900043: go/build: temporarily disable cgo for freebsd/arm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63900043: code review 63900043: go/build: temporarily disable cgo for freebsd/arm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by dave

Modified:
10 years, 3 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

go/build: temporarily disable cgo for freebsd/arm Update issue 7331 cgo is currently broken on freebsd/arm.

Patch Set 1 #

Patch Set 2 : diff -r 5cfa01069440 https://code.google.com/p/go #

Patch Set 3 : diff -r 5cfa01069440 https://code.google.com/p/go #

Patch Set 4 : diff -r 6c201ac1f315 https://code.google.com/p/go #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/pkg/go/build/build.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 3 months ago (2014-02-14 10:29:28 UTC) #1

dave_cheney.net

*** Submitted as https://code.google.com/p/go/source/detail?r=b29b14df7e45 *** go/build: temporarily disable cgo for freebsd/arm Update issue 7331 cgo ...

10 years, 3 months ago (2014-02-16 09:47:01 UTC) #3

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64 builder.

Expand All Messages | Collapse All Messages