Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3122)

Issue 6373047: code review 6373047: testing: fix memory blowup when formatting many lines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by remyoudompheng
Modified:
11 years, 8 months ago
Reviewers:
CC:
golang-dev, r, remy_archlinux.org
Visibility:
Public.

Description

testing: fix memory blowup when formatting many lines. Fixes issue 3830.

Patch Set 1 #

Patch Set 2 : diff -r c61c67c7b924 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c61c67c7b924 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6c441dee919c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M src/pkg/testing/testing.go View 1 3 chunks +34 lines, -28 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 8 months ago (2012-07-15 18:02:42 UTC) #1
r
LGTM
11 years, 8 months ago (2012-07-16 22:23:59 UTC) #2
remyoudompheng
11 years, 8 months ago (2012-07-17 05:56:36 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=5e7fd762f356 ***

testing: fix memory blowup when formatting many lines.

Fixes issue 3830.

R=golang-dev, r
CC=golang-dev, remy
http://codereview.appspot.com/6373047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b