Issue 6354066: code review 6354066: cmd/pack: remove unused paging logic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6354066: code review 6354066: cmd/pack: remove unused paging logic (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by dave

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, r, brad_danga_com, minux1

Visibility:
Public.

Description

cmd/pack: remove unused paging logic This is the remainder of http://codereview.appspot.com/4601051. Partially addresses issue 2705.

Patch Set 1 #

Patch Set 2 : diff -r 4a9c9c802565 https://code.google.com/p/go #

Patch Set 3 : diff -r 080799c3785f https://code.google.com/p/go #

Patch Set 4 : diff -r 080799c3785f https://code.google.com/p/go #

Patch Set 5 : diff -r 81f45da9df0d https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -57 lines)			Patch
	M	src/cmd/pack/ar.c	View	1	6 chunks	+6 lines, -57 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 9 months ago (2012-07-06 13:36:24 UTC) #1

dave_cheney.net

Thanks r +bradfitz (as this is working towards fixing the issue he identified)

12 years, 8 months ago (2012-07-09 23:02:22 UTC) #3

dave_cheney.net

12 years, 8 months ago (2012-07-12 00:14:30 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=2874979af37a ***

cmd/pack: remove unused paging logic

This is the remainder of http://codereview.appspot.com/4601051.

Partially addresses issue 2705.

R=golang-dev, r, bradfitz, minux.ma
CC=golang-dev
http://codereview.appspot.com/6354066

Expand All Messages | Collapse All Messages