Issue 6352093: code review 6352093: crypto/rsa: left-pad PKCS#1 v1.5 outputs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6352093: code review 6352093: crypto/rsa: left-pad PKCS#1 v1.5 outputs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by agl1

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, eds2, r

Visibility:
Public.

Description

crypto/rsa: left-pad PKCS#1 v1.5 outputs. OpenSSL requires that RSA signatures be exactly the same byte-length as the modulus. Currently it'll reject ~1/256 of our signatures: those that end up a byte shorter. Fixes issue 3796.

Patch Set 1 #

Patch Set 2 : diff -r 63d9b9b595c5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 63d9b9b595c5 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 744f0397f41a https://code.google.com/p/go/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -7 lines)			Patch
	M	src/pkg/crypto/rsa/pkcs1v15.go	View	1 2 3	4 chunks	+22 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 8 months ago (2012-07-10 23:22:50 UTC) #1

eds2

LGTM (but definitely get more opinions), thanks for the quick fix. http://codereview.appspot.com/6352093/diff/5001/src/pkg/crypto/rsa/pkcs1v15.go File src/pkg/crypto/rsa/pkcs1v15.go (right): ...

12 years, 8 months ago (2012-07-11 00:33:48 UTC) #2

agl1

12 years, 8 months ago (2012-07-11 16:47:20 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=46ca86e70e96 ***

crypto/rsa: left-pad PKCS#1 v1.5 outputs.

OpenSSL requires that RSA signatures be exactly the same byte-length
as the modulus. Currently it'll reject ~1/256 of our signatures: those
that end up a byte shorter.

Fixes issue 3796.

R=golang-dev, edsrzf, r
CC=golang-dev
http://codereview.appspot.com/6352093

http://codereview.appspot.com/6352093/diff/5001/src/pkg/crypto/rsa/pkcs1v15.go
File src/pkg/crypto/rsa/pkcs1v15.go (right):

http://codereview.appspot.com/6352093/diff/5001/src/pkg/crypto/rsa/pkcs1v15.g...
src/pkg/crypto/rsa/pkcs1v15.go:28: // EM = 0x02 || PS || 0x00 || M
On 2012/07/11 00:33:48, eds2 wrote:
> I don't totally understand the code change here, but should this comment be
> updated to:
> 
> // EM = 0x00 || 0x02 || PS || 0x00 || M

That's probably clearer, thanks. (Done.)

Expand All Messages | Collapse All Messages