Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(240)

Issue 6307065: code review 6307065: syscall: revert API changes in Windows Win32finddata fix. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by rsc
Modified:
12 years, 9 months ago
Reviewers:
brainman
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

syscall: revert API changes in Windows Win32finddata fix. Preserve old API by using correct struct in system call and then copying the results, as we did for SetsockoptLinger.

Patch Set 1 #

Patch Set 2 : diff -r b4cdcec897fb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8e7ad2db0833 https://go.googlecode.com/hg/ #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -42 lines) Patch
M api/next.txt View 1 1 chunk +0 lines, -26 lines 0 comments Download
M src/pkg/os/file_windows.go View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/syscall/syscall_windows.go View 1 2 3 chunks +22 lines, -5 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_amd64.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/syscall/ztypes_windows.go View 1 2 3 chunks +20 lines, -4 lines 2 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2012-06-08 17:44:04 UTC) #1
bradfitz
LGTM On Fri, Jun 8, 2012 at 10:44 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
12 years, 9 months ago (2012-06-08 17:46:22 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=7a7a91c3da32 *** syscall: revert API changes in Windows Win32finddata fix. Preserve old ...
12 years, 9 months ago (2012-06-08 17:54:56 UTC) #3
brainman
Sorry, I am late to the party. Alex http://codereview.appspot.com/6307065/diff/7001/src/pkg/syscall/ztypes_windows.go File src/pkg/syscall/ztypes_windows.go (right): http://codereview.appspot.com/6307065/diff/7001/src/pkg/syscall/ztypes_windows.go#newcode381 src/pkg/syscall/ztypes_windows.go:381: dst.FileName[len(dst.FileName)-1] ...
12 years, 9 months ago (2012-06-09 12:15:31 UTC) #4
rsc
12 years, 9 months ago (2012-06-13 19:22:05 UTC) #5
On Sat, Jun 9, 2012 at 8:15 AM,  <alex.brainman@gmail.com> wrote:
> Sorry, I am late to the party.

Not at all; thank you for pointing these out. I will send out a CL,
and it will be included in the release. I might even resurrect my
Windows VM and try to test them.

Russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b