Issue 6306051: code review 6306051: encoding/json: fix panic unmarshaling into non-nil inte...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6306051: code review 6306051: encoding/json: fix panic unmarshaling into non-nil inte... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rsc

Modified:
11 years, 10 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

encoding/json: fix panic unmarshaling into non-nil interface value Fixes issue 3614.

Patch Set 2 : diff -r d39a44280dd3 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r d39a44280dd3 https://go.googlecode.com/hg/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -2 lines)			Patch
	M	src/pkg/encoding/json/decode.go	View	1 2	1 chunk	+7 lines, -2 lines	0 comments	Download
	M	src/pkg/encoding/json/decode_test.go	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 10 months ago (2012-06-07 05:30:18 UTC) #1

adg

http://codereview.appspot.com/6306051/diff/2001/src/pkg/encoding/json/decode.go File src/pkg/encoding/json/decode.go (right): http://codereview.appspot.com/6306051/diff/2001/src/pkg/encoding/json/decode.go#newcode281 src/pkg/encoding/json/decode.go:281: v = iv.Elem() v = e ?

11 years, 10 months ago (2012-06-07 05:35:54 UTC) #2

rsc

11 years, 10 months ago (2012-06-07 05:49:02 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=bee83c1509a3 ***

encoding/json: fix panic unmarshaling into non-nil interface value

Fixes issue 3614.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/6306051

Expand All Messages | Collapse All Messages