Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2622)

Issue 6303061: code review 6303061: syscall: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by rsc
Modified:
11 years, 10 months ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

syscall: fix windows build

Patch Set 1 #

Patch Set 2 : diff -r 7a7a91c3da32 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7a7a91c3da32 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/syscall/syscall_windows_test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 10 months ago (2012-06-08 18:04:43 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=17432a753e50 *** syscall: fix windows build TBR=bradfitz CC=golang-dev http://codereview.appspot.com/6303061
11 years, 10 months ago (2012-06-08 18:04:51 UTC) #2
bradfitz
11 years, 10 months ago (2012-06-08 18:07:44 UTC) #3
LGTM

On Fri, Jun 8, 2012 at 11:04 AM, <rsc@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> syscall: fix windows build
>
> Please review this at
http://codereview.appspot.com/**6303061/<http://codereview.appspot.com/6303061/>
>
> Affected files:
>  M src/pkg/syscall/syscall_**windows_test.go
>
>
> Index: src/pkg/syscall/syscall_**windows_test.go
> ==============================**==============================**=======
> --- a/src/pkg/syscall/syscall_**windows_test.go
> +++ b/src/pkg/syscall/syscall_**windows_test.go
> @@ -27,7 +27,7 @@
>        f.Close()
>
>        type X struct {
> -               fd  syscall.Win32finddata1
> +               fd  syscall.Win32finddata
>                got byte
>                pad [10]byte // to protect ourselves
>
> @@ -35,7 +35,7 @@
>        var want byte = 2 // it is unlikely to have this character in the
> filename
>        x := X{got: want}
>
> -       h, err := syscall.FindFirstFile1(**syscall.StringToUTF16Ptr(path)*
> *, &(x.fd))
> +       h, err := syscall.FindFirstFile(syscall.**StringToUTF16Ptr(path),
> &(x.fd))
>        if err != nil {
>                t.Fatalf("FindFirstFile failed: %v", err)
>        }
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b