code review 6301059: cmd/gc: fix type checking loop

cmd/gc: fix type checking loop

CL 4313064 fixed its test case but did not address a
general enough problem:

type T1 struct { F *T2 }
type T2 T1
type T3 T2

could still end up copying the definition of T1 for T2
before T1 was done being evaluated, or T3 before T2
was done.

In order to propagate the updates correctly,
record a copy of an incomplete type for re-execution
once the type is completed. Roll back CL 4313064.

Fixes issue 3709.

[rsc, 2012-06-07 07:06:38]

Hello ken2 (cc: golang-dev@googlegroups.com, lstoakes),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-06-07 07:06:48]

*** Submitted as http://code.google.com/p/go/source/detail?r=e69400ace361 ***

cmd/gc: fix type checking loop

CL 4313064 fixed its test case but did not address a
general enough problem:

type T1 struct { F *T2 }
type T2 T1
type T3 T2

could still end up copying the definition of T1 for T2
before T1 was done being evaluated, or T3 before T2
was done.

In order to propagate the updates correctly,
record a copy of an incomplete type for re-execution
once the type is completed. Roll back CL 4313064.

Fixes issue 3709.

R=ken2
CC=golang-dev, lstoakes
http://codereview.appspot.com/6301059

[ken3, 2012-06-07 08:17:32]

lgtm